-
Notifications
You must be signed in to change notification settings - Fork 340
Add s2geometry.io website source from github.com/manshreck/s2geometry.github.io #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
These should really be added back to the util/geometry/opensource export. Most (all?) of these files exist in util/geometry/g3doc/. It's just going to cause problems to add them separately. |
| // Copyright 2017 Google Inc. All Rights Reserved. | ||
| // Author: [email protected] (Eric Veach) | ||
| // | ||
| // This example shows how to add spatial data to an information retrieval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have https://github.com/google/s2geometry/blob/master/doc/examples/term_index.cc.
These trees need to be unified more carefully.
| @@ -0,0 +1,28 @@ | |||
| source "https://rubygems.org" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this Gemfile here?
| @@ -0,0 +1,204 @@ | |||
| Apache License | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is another license being added?
|
#473 related |
|
What's with the CNAME changes? Why is CNAME being deleted? |
Hi @jmr, Good question. The CNAME file is managed by GitHub's Pages service. It was automatically deleted when the custom domain in the repository settings was explicitly cleared. GitHub will auto-generate the CNAME file again once "s2geometry.io" is set as the custom domain in the settings for the repository that will host the live site. This action is currently blocked because the domain is still associated with the old "manshreck/s2geometry.github.io" repository. After that association is removed, we can configure the domain here and the file will be automatically populated by GitHub. |
Hi team,
This pull request adds the source code for the s2geometry.io website. The goal is to migrate the site to a Google-controlled repository. This will allow us to fix the HTTPS certificate issue and resolve the "Not Secure" browser warning.
Directory Choice:
/docsThe website source files have been placed in the
/docsdirectory.I understand that having both a
/docand a/docsdirectory might seem a bit confusing. The/docsdirectory was chosen because this is the standard folder name that GitHub Pages uses to publish a website from themasterbranch.We can discuss changing this structure in the future if the current arrangement is inconvenient for the team.
Next Steps
After this PR is merged, the
s2geometry.iocustom domain can be configured in the repository settings to serve from this/docsfolder, and the DNS records can be updated.Thanks!